[iOS] Picker not displayed when not on main view controller #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrieve the top view controller from the view hierarchy and display picker
dan15d
changed the title
|
Thanks for reporting that! |
|
Unfortunately, LocalUIViewController.current requires a @composable context and the onLaunch callback of FilePickerLauncher doesn't have this context. |
|
Yes that's ok, it can be created on Compose: |
|
That works! Do you want me to upload the changes? |
|
Yes |
[iOS] Use LocalUIViewController.current to show the picker
|
It need to be added as a key to the remember as well: ...
return remember(currentUiViewController) {
FilePickerLauncher(
... |
Miss import
|
Also, you forgot to push the import for |
|
yes, i fix it. sorry |
pass the currentUIViewController on remember
MohamedRejeb
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieve the top view controller from the view hierarchy and display picker.
In the current versión i get this error:
Attempt to present <UIDocumentPickerViewController: 0x10c80ac00> on <.MainViewController: 0x10a0099f0> (from <.MainViewController: 0x10a0099f0>) whose view is not in the window hierarchy.